Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove instructions for Ubuntu 12.04 Trusty, which is no longer supported. #2039

Merged
merged 5 commits into from
Apr 11, 2016

Conversation

david-german-tri
Copy link
Contributor

Resolves #2015


This change is Reviewable   Multiple assignees: @RussTedrake RussTedrake, @david-german-tri david-german-tri, @jwnimmer-tri jwnimmer-tri

# Ubuntu 12.04 LTS (Precise)
sudo add-apt-repository -y "deb http://llvm.org/apt/precise/ llvm-toolchain-precise-3.7 main"
sudo add-apt-repository -y ppa:kalakris/cmake

# Ubuntu 14.04 LTS (Trusty)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment still appears here and on line 26. I am unclear on what its purpose is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jwnimmer-tri
Copy link
Collaborator

In general, I would also like @RussTedrake to sign off on dropping this platform, before we proceed.

@jwnimmer-tri
Copy link
Collaborator

LGTM.

@RussTedrake
Copy link
Contributor

Can we make the changelog show that we cut this support, and provide a pointer back to this PR. That way an adventurous 12.04 user could still find his/her way to the old instructions if necessary?

@@ -10,11 +10,6 @@ Install the prerequisites::
sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test
wget -q -O - http://llvm.org/apt/llvm-snapshot.gpg.key | sudo apt-key add -

# Ubuntu 12.04 LTS (Precise)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a test comment in GitHub to see how it shows up in Reviewable.

@david-german-tri
Copy link
Contributor Author

Added to Changelog.

@jwnimmer-tri
Copy link
Collaborator

CHANGELOG.md, line 32 [r3] (raw file):
Past tense in commit messages and changelogs is a pet peeve of mine. I am not sure I want to inflict that opinion on Drake, but perhaps consider whether you want to stick with present or subjunctive tense in this case?


Comments from Reviewable

@david-german-tri
Copy link
Contributor Author

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.


CHANGELOG.md, line 32 [r3] (raw file):
Why not. Done.


Comments from Reviewable

@jwnimmer-tri
Copy link
Collaborator

Reviewed 1 of 1 files at r2, 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jwnimmer-tri
Copy link
Collaborator

:lgtm:


Comments from Reviewable

@david-german-tri
Copy link
Contributor Author

+@jwnimmer-tri +@RussTedrake

Hey look, Reviewable supports multiple assignees with this syntax.


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@david-german-tri
Copy link
Contributor Author

@jamiesnape, looks like there was an infrastructure flake in the Mac CI: "Slave went offline during the build"

https://drake-jenkins.csail.mit.edu/job/experimental/758/compiler=clang,label=mac/console


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@david-german-tri
Copy link
Contributor Author

I'm going to merge despite the flake.


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants