-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced valuecheckMatrix() with CompareMatrices(). Updated some unit tests use Google Test. #1953
Replaced valuecheckMatrix() with CompareMatrices(). Updated some unit tests use Google Test. #1953
Conversation
…must_be_implicitly_convertible_to_U error.
…d logic for handling corner cases like infinity, NaN, and tolerance.
… all calls to valuecheckMatrix().
# Conflicts: # drake/solvers/test/testOptimizationProblem.cpp
@@ -3,9 +3,34 @@ | |||
#include "drake/solvers/Optimization.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alphabetize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Added a bunch of minor comments. Obviously, many of the tests you've migrated are still in a clunky state, but I didn't pile comments onto those - this change is a huge improvement! |
…o feature/matrixMatcher
@david-german-tri: Thanks for the thorough code review. I believe I addressed all of your comments. Can you verify the changes and merge if everything is acceptable? |
InputOutputRelation::Form::POLYNOMIAL); | ||
|
||
EXPECT_EQ(InputOutputRelation::composeWith(f, g).form, | ||
InputOutputRelation::Form::POLYNOMIAL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like everything should be clang-formatted again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@david-german-tri: I just ran clang-format and noticed it may be violating the style guide's specification on the order of includes. Here is an example change made by clang-format:
Shouldn't gtest.h
be considered "other libraries' .h" meaning it should go before drake's header files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the problem that you should use <gtest/gtest.h>
and not "gtest/gtest.h"
?
The CI servers found a problem that I failed to detect due to the fact that I did not have Matlab installed on any of my local machines:
|
Here's a final suggestion, taken from the changelog -- for any users who consult this PR for advice: Unit tests that originally contained
should be modified to use Google Test and the following line:
|
Closes #1916.
Getting this merged is a prerequisite for #1898.