Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ros-workspace test to catkin build scripts. #9

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

nuclearsandwich
Copy link
Contributor

The ros_workspace package is a plain CMake (as opposed to an ament_cmake) package and thus uses the catkin build scripts rather than the ament_cmake build scripts.

By moving this test I'm able to locally generate scripts with vinca that add activation and deactivation scripts.

❯ tar tf /home/steven/mambaforge/conda-bld/linux-64/ros-galactic-ros-workspace-1.0.2-py38he9ab703_99.tar.bz2 | sort |grep '^etc'         (base)
etc/conda/activate.d/ros-galactic-ros-workspace_activate.sh
etc/conda/deactivate.d/ros-galactic-ros-workspace_deactivate.sh

The ros_workspace package is a plain CMake (as opposed to an
ament_cmake) package and thus uses the catkin build scripts rather than
the ament_cmake build scripts.
@wolfv wolfv merged commit cbffff3 into RoboStack:ros2 Jul 19, 2021
@wolfv
Copy link
Member

wolfv commented Jul 19, 2021

cool! let's rebuild the packages.

@Tobias-Fischer
Copy link
Contributor

Just needs rebuilding of ros-workspace? Are you on it, or should I do it @wolfv?

@wolfv
Copy link
Member

wolfv commented Jul 19, 2021

It should be done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants