use cached repodata.json #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gotcha, thanks for that! Agreed that using the repodata.json is probably the better way to go. |
|
Ok, this now sorts based on the whole tree! Takes a bit more time, but results are better! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tobias-Fischer I am continuing here.
The remaining problem is about the graph sorting.
Basically we have a subset of packages that need to be migrated. However, if we only topologically sort the packages that need to be migrated then we don't end up with the proper sorting. We need to sort the entire graph and then use that to find the right order to build the packages in.
For that we could use either the repodata.json or the rosdistro data. I think I'd like to use the repodata.json info for now, and see if that works out.