Add ros2 version suffix. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ros2` branch does not distinguish itself at runtime from the `master` branch. This adds an indicator to the version string which indicates it is based on the ROS 2 branch which makes it much easier to tell what you're using.
|
LGTM - should we merge @wolfv? |
Tobias-Fischer
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ros2branch does not distinguish itself at runtime from themasterbranch. This adds an indicator to the version string which indicates it
is based on the ROS 2 branch which makes it much easier to tell what
you're using.
I'm not sure whether this is the preferred way to do this but I'm open to alternatives as well.