Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug? Should this two lines checking setup.cfg be swapped? #46

Closed
0wu opened this issue Jan 28, 2024 · 2 comments · Fixed by #48 or #49
Closed

Bug? Should this two lines checking setup.cfg be swapped? #46

0wu opened this issue Jan 28, 2024 · 2 comments · Fixed by #48 or #49

Comments

@0wu
Copy link

0wu commented Jan 28, 2024

result=$?
grep -q "install[-_]scripts" setup.cfg || true
if [ $result -eq 0 ]; then

I assume $result should indicate if there's a setup.cfg

@0wu 0wu changed the title Should this two lines be swapped? Bug? Should this two lines checking setup.cfg be swapped? Jan 28, 2024
@Tobias-Fischer
Copy link
Contributor

Ouch .. definitely a bug. /cc @traversaro

@traversaro
Copy link
Member

Indeed, this seems a regression of 8be7ab8 . Indeed, I tried with:

mamba create -n testdemotalker -c conda-forge -c robostack-staging ros-humble-demo-nodes-py ros-humble-ros2run
mamba activate testdemotalker
traversaro@IITBMP014LW012:~$ ros2 run demo_nodes_py demo_talker
No executable found

So we have a regression w.r.t. RoboStack/ros-humble#41 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants