Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release as package into ROS #33

Open
bochen87 opened this issue Apr 22, 2021 · 9 comments
Open

Release as package into ROS #33

bochen87 opened this issue Apr 22, 2021 · 9 comments

Comments

@bochen87
Copy link

Hi, are there plans to release as a packge into ROS?

@HaoQChen
Copy link
Contributor

What's the benifit to do that?

easy to install?

@bochen87
Copy link
Author

yes, basically you can then install as a package instead of compilation from source.

@HaoQChen
Copy link
Contributor

Compilation from source will give user more option to choose what they need. For example, some users dont need ROS and they dont even have the environment of ROS while some need that to communicate.

In our test, the compilation of rslidar_sdk just costs a few seconds, is that unacceptable?

Or it is hard to clone the code from github? The transmission speed from github is slow?

Or you need a deb to install to other computers? You can download source code and compile it to a deb, bloom-generate, fakeroot will help you with that. In this way, you can totally offline.

@Timple
Copy link
Contributor

Timple commented Jun 10, 2021

Yes, ease of installation is definitely important!

For example, some users dont need ROS

They can still install from source of course.

Or it is hard to clone the code from github?

Yes, you need to clone. And modify CMakeLists.txt file. And move a package.xml file.

So all our robots that would use this lidar would need to do this. But also in CI: instead of rosdep install you need to perform the steps above. Which are a-typical. And they would need to be programmed into every repository using this dependency.

Alternative: we could generate the .deb ourselves. But then we should host it somewhere, download it from a custom location on every CI run etc.

While on the other hand, a bloom release is a process which would take a couple of hours to configure. And as of then, everybody using ROS would have the benefit of avoiding the above 🙂

As we have an interest in this lidar, I would be happy to help in this process.

@HaoQChen
Copy link
Contributor

Yes, ease of installation is definitely important!

For example, some users dont need ROS

They can still install from source of course.

Or it is hard to clone the code from github?

Yes, you need to clone. And modify CMakeLists.txt file. And move a package.xml file.

So all our robots that would use this lidar would need to do this. But also in CI: instead of rosdep install you need to perform the steps above. Which are a-typical. And they would need to be programmed into every repository using this dependency.

Alternative: we could generate the .deb ourselves. But then we should host it somewhere, download it from a custom location on every CI run etc.

While on the other hand, a bloom release is a process which would take a couple of hours to configure. And as of then, everybody using ROS would have the benefit of avoiding the above

As we have an interest in this lidar, I would be happy to help in this process.

copy that, we will seriously consider this matter

@Timple
Copy link
Contributor

Timple commented Jul 23, 2021

#48 Is all that is required for this I guess.

Now only the tutorial needs to be followed: http://wiki.ros.org/bloom/Tutorials/FirstTimeRelease

@Timple
Copy link
Contributor

Timple commented Oct 21, 2021

Are there any objections if I release the package to the buildfarm?

@Timple
Copy link
Contributor

Timple commented Nov 29, 2021

Silence means consent?

@Timple
Copy link
Contributor

Timple commented Jan 3, 2022

Via email I got the approval to release this package. I will hold for a week to see if #48 and #52 will be merged first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants