Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade chalk, remove has-ansi and strip-ansi #1370

Merged
merged 26 commits into from
Dec 11, 2023
Merged

Upgrade chalk, remove has-ansi and strip-ansi #1370

merged 26 commits into from
Dec 11, 2023

Conversation

RobinTail
Copy link
Owner

Requires #1369 (for ansi packages)

@RobinTail
Switching unit, system, integration and ESM tests to vitest.
2428aab
@RobinTail
Making compatibility test to test against jest.
b20c9dc
@RobinTail
Restoring jest as optional peer.
11b8375
@RobinTail
Fix compatibility test: each and dependencies.
8d5d99b
@RobinTail
Ref: combining imports in test.
2d09e45
@RobinTail
Minor: jsdoc.
3370420
@RobinTail
Deduplicating by upgrading all dependencies.
6b58682
@RobinTail
Ref: extracting makeLoggerMock() and reusing testing helpers in resul…
b38d9a1 
…t handler test instead of let.
@RobinTail
Ref: replacing let loggerMock in routing test.
cbe8719
@RobinTail
Ref: reusing appMock from express-mock in routing test.
0b98bd4
@RobinTail
Ref: replacing let in App system test, using the power of async descr…
150c39c 
…ibe (vitest feature).
@RobinTail
Ref: replacing let with await in async describe of ESM, integration a…
69603f3 
…nd 2 system tests, completely.
@RobinTail
Verbose reporter.
5ac2cd2
@RobinTail
Upgrading chalk, adjusting startup logo tool.
95e1a72
@RobinTail
Upgrading has-ansi and strip-ansi.
29a84bd
@RobinTail RobinTail added dependencies Pull requests that update a dependency file refactoring The better way to achieve the same result labels Dec 10, 2023
@RobinTail RobinTail marked this pull request as ready for review December 10, 2023 21:20
RobinTail
RobinTail commented Dec 10, 2023
View reviewed changes
RobinTail
RobinTail commented Dec 10, 2023
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Base automatically changed from switch-to-vitest to master December 11, 2023 14:26
@coveralls
Copy link

coveralls commented Dec 11, 2023 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 39edf29 on upgrade-chalk
into 1aaa26a on master.

@RobinTail
Copy link
Owner Author

I'm wondering if I can get rid of ansi packages

@RobinTail RobinTail changed the title Upgrade chalk, has-ansi and strip-ansi Upgrade chalk, removing has-ansi and strip-ansi Dec 11, 2023
@RobinTail RobinTail changed the title Upgrade chalk, removing has-ansi and strip-ansi Upgrade chalk, remove has-ansi and strip-ansi Dec 11, 2023
RobinTail
RobinTail commented Dec 11, 2023
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful

@RobinTail RobinTail merged commit dbbae56 into master Dec 11, 2023
@RobinTail RobinTail deleted the upgrade-chalk branch December 11, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file refactoring The better way to achieve the same result
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobinTail @coveralls