Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device ATmega644. #3

Merged
2 commits merged into from
Jul 20, 2019
Merged

Add device ATmega644. #3

2 commits merged into from
Jul 20, 2019

Conversation

5inf
Copy link
Contributor

@5inf 5inf commented Jul 20, 2019

"Fix" for Issue #2.

@ghost
Copy link

ghost commented Jul 20, 2019

Has this been tested on real hardware? What about including the include file?

@5inf
Copy link
Contributor Author

5inf commented Jul 20, 2019

Include file added, taken from https://github.com/DarkSector/AVR/blob/master/asm/include/m644def.inc In a quick test it seemed to have worked on hardware (see https://github.com/5inf/uprog2). I can do a more testing next week.

@ghost
Copy link

ghost commented Jul 20, 2019

It's alright, no need to test thoroughly. Knowing that it has actually run on real hardware is enough. If someone has a problem with this configuration, they can always amend it. Merging, thanks.

@ghost ghost merged commit 55a17c3 into Ro5bert:master Jul 20, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant