Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Doing a lot of cleanup in the code XML here #129

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conversation

Rnen
Copy link
Owner

@Rnen Rnen commented Jul 3, 2022

Figured this tool was pretty nifty to get a good overview
https://livedocumenter.barryjones.me.uk/

Figured this tool was pretty nifty to get a good overview
https://livedocumenter.barryjones.me.uk/
@Rnen
Copy link
Owner Author

Rnen commented Jul 3, 2022

Gonna do more later this week.
@ElectronicsArchiver you might be interested in this, idk.

@ElectronicsArchiver
Copy link
Contributor

Figured this tool was pretty nifty to get a good overview https://livedocumenter.barryjones.me.uk/

This will only work on Windows at the moment,

🠖 I'm on Linux~

@ElectronicsArchiver
Copy link
Contributor

On that note, the plugin only works for windows correct?
If so, I'd add a note for that in the README.

@Rnen
Copy link
Owner Author

Rnen commented Jul 4, 2022

On that note, the plugin only works for windows correct? If so, I'd add a note for that in the README.

No idea 🤷 Have no devices to test that on. If SMod works on Linux then in theory the plugin should work as well

@ElectronicsArchiver
Copy link
Contributor

I was asking because the default value for
the AdminToolbox path was described as a
Windows specific path~

@Rnen
Copy link
Owner Author

Rnen commented Jul 4, 2022

I was asking because the default value for the AdminToolbox path was described as a Windows specific path~

As it currently stands, the config is empty by default, and uses the game's FileManager to get the location. This should support Linux

private static string GetFolderPath()
{
string cnfgpath = Config.GetStringValue("admintoolbox_folder_path", string.Empty);
if (!string.IsNullOrEmpty(cnfgpath))
{
if (!cnfgpath.EndsWith(Path.DirectorySeparatorChar.ToString()))
cnfgpath += Path.DirectorySeparatorChar;
cnfgpath += "AdminToolbox" + Path.DirectorySeparatorChar;
}
else
{
cnfgpath = FileManager.GetAppFolder(addSeparator: true) + "AdminToolbox" + Path.DirectorySeparatorChar;
}
if (!Directory.Exists(cnfgpath))
Directory.CreateDirectory(cnfgpath);
return cnfgpath;
}

@Rnen Rnen marked this pull request as ready for review July 19, 2022 19:29
@Rnen Rnen merged commit fdf5060 into master Jul 19, 2022
@Rnen Rnen deleted the documenting-code branch July 19, 2022 19:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants