Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set fixed size to historyButtonPanel #1611

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

Isaaku
Copy link
Contributor

@Isaaku Isaaku commented Mar 29, 2020

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Description

Set fixed size to historyButtonPanel

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

Copy link

@perpetualogic perpetualogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you got this, I was just about to make the same change :)

@metaprime metaprime changed the base branch from master to main January 6, 2025 14:13
@metaprime metaprime merged commit 9dcb640 into RipMeApp:main Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-rip checked button row disappears when window 835 pixels or taller
3 participants