Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature to use Hipchat Server #20

Merged
merged 5 commits into from
Dec 19, 2014

Conversation

netmarkjp
Copy link
Contributor

I wrote small patch to add feature to use this module with Hipchat Server.

Default behavior did not change

regex pattern in hypchat.restobject._urls_to_objects change to short.
I think this change has no effect in practical.

regards.

@AstraLuma
Copy link
Contributor

  1. Python 3 is now supported. str.format() should be used instead of %.
  2. Prefixing all the regexes with .* just smells of trouble.
  3. None of the support/testing scripts were adjusted to support endpoints.

My suggestion for #2 is that Linker._obj_from_text() should be adjusted to remove the endpoint and the regex's only compared to e.g. /v2/room/foobar.

@netmarkjp
Copy link
Contributor Author

@astronouth7303 thanx for comment. fix that.

@rrreeeyyy
Copy link

👍

1 similar comment
@koemu
Copy link

koemu commented Dec 19, 2014

👍

successamp added a commit that referenced this pull request Dec 19, 2014
@successamp successamp merged commit 78b89c4 into RidersDiscountCom:master Dec 19, 2014
@successamp
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants