fix/tidy handling of object literal shorthand syntax #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh. I think this won't catch instances of things like Edit: Oh pt II. Actually it looks like #9 broke that shorthand, not this PR. Might as well fix that at the same time then. |
|
Fix and additional test pushed. |
|
nice. released 0.0.22 |
tanhauhau
pushed a commit
to tanhauhau/code-red
that referenced
this pull request
Sep 13, 2022
upgrade is-reference@^3.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14.
This also tidies up the logic here a little bit. I don't see any reason to be looking at the arrays that are the result of calling
handle(), so this is now just looking directly at thenode.