Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array push spread v8 #40

Closed
exced opened this issue Apr 28, 2020 · 0 comments · Fixed by #71
Closed

Array push spread v8 #40

exced opened this issue Apr 28, 2020 · 0 comments · Fixed by #71
Labels
enhancement New feature or request

Comments

@exced
Copy link

exced commented Apr 28, 2020 •
edited
Loading

Hi,
Coming from sveltejs/svelte#4694.
handlers.ts is using array push with spread operator in multiple places and it is causing max call stacks in v8 (too many params in a function call).
The issue is providing an example but I can come up with a repro if you want.
I'd like to handle it but I am not sure what you prefer: using for loops, array concat, or even using a codemod ? Or not handling it at all 😄
Cheers,
@Conduitry Conduitry added the enhancement New feature or request label May 9, 2020
@Conduitry Conduitry mentioned this issue May 20, 2020
Closed
milahu added a commit to milahu/code-red that referenced this issue Sep 6, 2021
@milahu
fix: Maximum call stack size exceeded (Rich-Harris#40)
d016094
@milahu milahu mentioned this issue Sep 6, 2021
Closed
milahu added a commit to milahu/code-red that referenced this issue Sep 10, 2021
@milahu
fix: Maximum call stack size exceeded (Rich-Harris#40)
4605d5b
dummdidumm pushed a commit to dummdidumm/code-red that referenced this issue Jan 29, 2022
[fix] introduce helper method to prevent push maximum call stack size…
f684027 
… exceeded error

Fixes Rich-Harris#40
Alternative to Rich-Harris#64
Part of sveltejs/svelte#4694
@dummdidumm dummdidumm mentioned this issue Jan 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@exced @Conduitry