Skip to content

Commit

Permalink
merge dev-v0.9.4
Browse files Browse the repository at this point in the history
  • Loading branch information
samussiah committed Aug 13, 2019
2 parents e156f54 + 0a937da commit a85d405
Show file tree
Hide file tree
Showing 10 changed files with 100 additions and 36 deletions.
36 changes: 24 additions & 12 deletions build/cat.js
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,10 @@
return new Promise(function(resolve, reject) {
cat.current.url =
cat.current.version === 'master'
? (cat.current.rootURL || cat.config.rootURL) + '/' + cat.current.name
? (cat.current.rootURL || cat.config.rootURL) +
'/' +
cat.current.name +
'@latest'
: (cat.current.rootURL || cat.config.rootURL) +
'/' +
cat.current.name +
Expand Down Expand Up @@ -800,21 +803,27 @@
});
var version = cat.controls.versionSelect.node().value;
cat.current.main = cat.controls.mainFunction.node().value;
cat.current.sub = cat.controls.subFunction.node().value;
cat.current.sub = cat.controls.subFunction.node().value.split('.');

function render(error, data) {
var myChart = void 0;
if (error) {
cat.status.loadStatus(cat.statusDiv, false, dataFilePath);
} else {
cat.status.loadStatus(cat.statusDiv, true, dataFilePath);
if (cat.current.sub) {
var myChart = window[cat.current.main][cat.current.sub](
'.cat-chart',
cat.current.config
if (cat.current.sub.join('') !== '') {
myChart = window[cat.current.main];
cat.current.sub.forEach(function(subsub) {
myChart = myChart[subsub];
});
myChart = myChart('.cat-chart', cat.current.config);
cat.status.chartCreateStatus(
cat.statusDiv,
cat.current.main,
cat.current.sub[0]
);
cat.status.chartCreateStatus(cat.statusDiv, cat.current.main, cat.current.sub);
} else {
var myChart = window[cat.current.main]('.cat-chart .chart', cat.current.config);
myChart = window[cat.current.main]('.cat-chart .chart', cat.current.config);
cat.status.chartCreateStatus(cat.statusDiv, cat.current.main);
}

Expand Down Expand Up @@ -933,7 +942,7 @@
var cssPath =
version !== 'master'
? cat.config.rootURL + '/Webcharts@' + version + '/css/webcharts.css'
: cat.config.rootURL + '/Webcharts/css/webcharts.css';
: cat.config.rootURL + '/Webcharts@latest/css/webcharts.css';

var current_css = getCSS().filter(function(f) {
return f.link == cssPath;
Expand Down Expand Up @@ -961,8 +970,8 @@
// --- load js --- //
var rendererPath =
version !== 'master'
? cat.config.rootURL + '/' + library + '@' + version + '/build/webcharts.js'
: cat.config.rootURL + '/Webcharts/build/webcharts.js';
? cat.config.rootURL + '/Webcharts@' + version + '/build/webcharts.js'
: cat.config.rootURL + '/Webcharts@latest/build/webcharts.js';

var current_js = getJS().filter(function(f) {
return f.link == rendererPath;
Expand Down Expand Up @@ -1065,6 +1074,9 @@
.data(cat.config.renderers)
.enter()
.append('option')
.attr('label', function(d) {
return d.sub ? d.name + ' (' + d.sub.split('.').pop() + ')' : d.name;
})
.text(function(d) {
return d.name;
});
Expand Down Expand Up @@ -1521,7 +1533,7 @@
cat.current.rootURL || cat.config.rootURL,
cat.current.version !== 'master'
? cat.current.name + '@' + cat.current.version
: cat.current.name,
: cat.current.name + '@latest',
cat.current.schema
].join('/');

Expand Down
2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<script type = 'text/javascript' src = 'https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/js/bootstrap.min.js'></script>
<script type = 'text/javascript' src = '//cdn.datatables.net/1.10.16/js/jquery.dataTables.min.js'></script>
<script type = 'text/javascript' src = './build/cat.js'></script>
<script type = 'text/javascript' src = 'https://cdn.jsdelivr.net/gh/RhoInc/data-library/dataFiles.js'></script>
<script type = 'text/javascript' src = 'https://cdn.jsdelivr.net/gh/RhoInc/data-library@latest/dataFiles.js'></script>

<link type = 'text/css' rel = 'stylesheet' href = './css/cat.css'>
<link type = 'text/css' rel = 'stylesheet' href = 'https://cdn.rawgit.com/RhoInc/webcharts/master/css/webcharts.css'>
Expand Down
54 changes: 54 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ var myCatConfig = {
rootURL: 'https://cdn.jsdelivr.net/gh/RhoInc',
dataURL: 'https://raw.githubusercontent.com/RhoInc/data-library/master/data/',
renderers: [

{
name: 'web-codebook',
main: 'webcodebook',
Expand Down Expand Up @@ -120,6 +121,59 @@ var myCatConfig = {
defaultData: 'clinical-trials/data-cleaning/visits.csv'
},

/**-------------------------------------------------------------------------------------------\
Dashboard charts
\-------------------------------------------------------------------------------------------**/

{
name: 'dashboard-charts',
main: 'dashboardCharts',
sub: 'renderers.accrual',
css: null,
schema: 'src/accrual/settings-schema.json',
defaultData: 'clinical-trials/data-cleaning/dashboard-accrual.csv'
},
{
name: 'dashboard-charts',
main: 'dashboardCharts',
sub: 'renderers.accrualOverTimeDerived',
css: null,
schema: 'src/accrual-over-time/settings-schema.json',
defaultData: 'clinical-trials/data-cleaning/dashboard-accrual.csv'
},
{
name: 'dashboard-charts',
main: 'dashboardCharts',
sub: 'renderers.accrualOverTime',
css: null,
schema: 'src/accrual-over-time/settings-schema.json',
defaultData: 'clinical-trials/data-cleaning/dashboard-accrual-over-time.csv'
},
{
name: 'dashboard-charts',
main: 'dashboardCharts',
sub: 'renderers.forms',
css: null,
schema: 'src/accrual/settings-schema.json',
defaultData: 'clinical-trials/data-cleaning/dashboard-forms.csv'
},
{
name: 'dashboard-charts',
main: 'dashboardCharts',
sub: 'renderers.queries',
css: null,
schema: 'src/accrual/settings-schema.json',
defaultData: 'clinical-trials/data-cleaning/dashboard-queries.csv'
},
{
name: 'dashboard-charts',
main: 'dashboardCharts',
sub: 'renderers.visitCompletion',
css: null,
schema: 'src/accrual/settings-schema.json',
defaultData: 'clinical-trials/data-cleaning/dashboard-visit-completion.csv'
},

/**-------------------------------------------------------------------------------------------\
Miscellaneous
\-------------------------------------------------------------------------------------------**/
Expand Down
13 changes: 4 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cat",
"version": "0.9.5",
"version": "0.9.4",
"description": "The Charting Application Tester (CAT) lets users make and adjust web graphics on the fly.",
"module": "./src/index.js",
"main": "./build/cat.js",
Expand Down
1 change: 1 addition & 0 deletions src/cat/controls/initRendererSelect.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export function initRendererSelect(cat) {
.data(cat.config.renderers)
.enter()
.append('option')
.attr('label', d => (d.sub ? d.name + ' (' + d.sub.split('.').pop() + ')' : d.name))
.text(d => d.name);

cat.controls.rendererSelect.on('change', function() {
Expand Down
6 changes: 3 additions & 3 deletions src/cat/loadLibrary.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export function loadLibrary(cat) {
var cssPath =
version !== 'master'
? cat.config.rootURL + '/Webcharts@' + version + '/css/webcharts.css'
: cat.config.rootURL + '/Webcharts/css/webcharts.css';
: cat.config.rootURL + '/Webcharts@latest/css/webcharts.css';

var current_css = getCSS().filter(f => f.link == cssPath);
var css_loaded = current_css.length > 0;
Expand All @@ -35,8 +35,8 @@ export function loadLibrary(cat) {
// --- load js --- //
var rendererPath =
version !== 'master'
? cat.config.rootURL + '/' + library + '@' + version + '/build/webcharts.js'
: cat.config.rootURL + '/Webcharts/build/webcharts.js';
? cat.config.rootURL + '/Webcharts@' + version + '/build/webcharts.js'
: cat.config.rootURL + '/Webcharts@latest/build/webcharts.js';

var current_js = getJS().filter(f => f.link == rendererPath);
var js_loaded = current_js.length > 0;
Expand Down
2 changes: 1 addition & 1 deletion src/cat/loadRenderer/loadPackageJson.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ export default function loadPackageJson(cat) {
return new Promise(function(resolve, reject) {
cat.current.url =
cat.current.version === 'master'
? `${cat.current.rootURL || cat.config.rootURL}/${cat.current.name}`
? `${cat.current.rootURL || cat.config.rootURL}/${cat.current.name}@latest`
: `${cat.current.rootURL || cat.config.rootURL}/${cat.current.name}@${
cat.current.version
}`;
Expand Down
18 changes: 10 additions & 8 deletions src/cat/renderChart.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,23 @@ export function renderChart(cat) {
var dataObject = cat.config.dataFiles.find(f => f.label == dataFile);
var version = cat.controls.versionSelect.node().value;
cat.current.main = cat.controls.mainFunction.node().value;
cat.current.sub = cat.controls.subFunction.node().value;
cat.current.sub = cat.controls.subFunction.node().value.split('.');

function render(error, data) {
let myChart;
if (error) {
cat.status.loadStatus(cat.statusDiv, false, dataFilePath);
} else {
cat.status.loadStatus(cat.statusDiv, true, dataFilePath);
if (cat.current.sub) {
var myChart = window[cat.current.main][cat.current.sub](
'.cat-chart',
cat.current.config
);
cat.status.chartCreateStatus(cat.statusDiv, cat.current.main, cat.current.sub);
if (cat.current.sub.join('') !== '') {
myChart = window[cat.current.main];
cat.current.sub.forEach(subsub => {
myChart = myChart[subsub];
});
myChart = myChart('.cat-chart', cat.current.config);
cat.status.chartCreateStatus(cat.statusDiv, cat.current.main, cat.current.sub[0]);
} else {
var myChart = window[cat.current.main]('.cat-chart .chart', cat.current.config);
myChart = window[cat.current.main]('.cat-chart .chart', cat.current.config);
cat.status.chartCreateStatus(cat.statusDiv, cat.current.main);
}

Expand Down
2 changes: 1 addition & 1 deletion src/cat/settings/set.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export function set(cat) {
cat.current.rootURL || cat.config.rootURL,
cat.current.version !== 'master'
? cat.current.name + '@' + cat.current.version
: cat.current.name,
: cat.current.name + '@latest',
cat.current.schema
].join('/');

Expand Down

0 comments on commit a85d405

Please sign in to comment.