Fix SDK Compilation on Xcode 16.3/iOS 18.4 Beta 1 #4814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RCGitBot please test |
ajpallares
approved these changes
Feb 22, 2025
There was a problem hiding this comment.
Thanks for the quick fix @fire-at-will! I have checked and this works for me with Xcode 16.3 beta whereas it doesn't without the change 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR addresses GH issue #4813. Apple released iOS 18.4 beta 1 and Xcode 16.3, which introduces the SubscriptionInfo typealias. This caused a name resolution conflict in
PurchaseInformation.swiftwhere the extension onSubscriptionInfocan't tell if it should resolve toStoreKit.SubscriptionInfoorRevenueCat.SubscriptionInfo.Description
This PR makes the extension's reference to
SubscriptionInfoexplicitly referenceRevenueCat.SubscriptionInfo, which resolves the compilation issue.Note to the Reviewer
Our iOS 18 CI jobs aren't using Xcode 16.3 yet, so just because this PR passes CI doesn't necessarily mean it will work. I've tested and confirmed that
RevenueCatUIon this branch builds for me on Xcode 16.3, but would appreciate it if you could try building as well to be safe.