UI preview mode: disable log in and log out #4804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
approved these changes
Feb 20, 2025
Exactly! I'm going one by one making sure that they are disabled in UI preview mode (even if they are not meant to be used while in UI preview mode). But #BetterSafeThanSorry 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation
Even though no calls to
logInorlogOutshould happen in UI preview mode, it's still appropriate to make sure that the SDK properly controls that scenario.Description
IdentityManagerfor thelogInandlogOutmethods, preventing any logic in this scenario (including any log in request to the backend)logInusing the app user ID reserved for UI preview mode also fails, even if UI preview mode is not enabled