UI Preview Mode: mock CustomerInfo
#4786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # RevenueCat.xcodeproj/project.pbxproj
tonidero
approved these changes
Feb 14, 2025
| @@ -189,6 +189,10 @@ class CustomerInfoManager { | |||
| } | |||
|
|
|||
| func cachedCustomerInfo(appUserID: String) -> CustomerInfo? { | |||
| guard !self.systemInfo.dangerousSettings.uiPreviewMode else { | |||
There was a problem hiding this comment.
Hmm I guess if we don't cache it, this would always be null and this might not be needed... But I guess I'm ok keeping it just in case.
There was a problem hiding this comment.
What you say makes total sense. The main reason why I also put this there is to always receive a nonnil CustomerInfo object, even when using CacheFetchPolicy.fromCacheOnly. Like: in UI Preview mode, you consistently get the mocked CustomerInfo every time and in any case (e.g. for any CacheFetchPolicy).
This was referenced Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation
In UI Preview mode, the SDK should not make the requests to obtain the
CustomerInfo.Description
When in UI Preview mode, the SDK:
CustomerInfoCustomerInfo(if requested either from the cache or from the backend)