Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce refund window to control if a refund is offered for a purchase #4784

Merged
merged 16 commits into from
Feb 25, 2025
Merged

feat: Introduce refund window to control if a refund is offered for a purchase #4784

merged 16 commits into from
Feb 25, 2025

Conversation

facumenzella
Copy link
Contributor

Motivation

We're giving more power to users by adding one setting in the dashboard. A default window can be added to show / hide the refund action in the Customer Center

Description

  • RefundWindowDuration
  • latestPurchaseDate added to PurchaseInformation
  • Use clock to mock current time and test it
  • Added doc to Clock forced by linter 🙃

Follow-up of #4776

@facumenzella facumenzella requested review from vegaro and a team February 13, 2025 12:43
ajpallares
ajpallares reviewed Feb 13, 2025
View reviewed changes
Copy link
Member

@ajpallares ajpallares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly OK, although there are some unnecessary @_spi(Internal) that should be removed. I don't think I should approve this one as I lack most of the context, but I've left some comments to improve this PR

@facumenzella facumenzella requested a review from a team February 18, 2025 08:26
ajpallares
ajpallares reviewed Feb 18, 2025
View reviewed changes
Copy link
Member

@ajpallares ajpallares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Looks good to me, but as I said before, I leave approval to someone with actual context about the logic behind these changes

tonidero
tonidero reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment about the naming but looking good!

vegaro
vegaro approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@vegaro vegaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than that question, it looks good to me

@facumenzella facumenzella enabled auto-merge (squash) February 25, 2025 11:47
@facumenzella facumenzella merged commit 7547196 into main Feb 25, 2025
10 checks passed
@facumenzella facumenzella deleted the feat/refund_window branch February 25, 2025 12:13
@RCGitBot RCGitBot mentioned this pull request Feb 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vegaro vegaro vegaro approved these changes

@ajpallares ajpallares ajpallares left review comments

@tonidero tonidero Awaiting requested review from tonidero

Assignees
No one assigned
Labels
feat:Customer Center pr:feat A new feature pr:RevenueCatUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@facumenzella @vegaro @tonidero @ajpallares