Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Track impression in CustomerCenter only once #4778

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

facumenzella
Copy link
Contributor

@facumenzella facumenzella commented Feb 10, 2025

Motivation

We've noticed trackImpression gets called multiple times per session. This PR addresses that

Description

impression event should be tracked only once per session
The PR adds a simple check like its done in the Android repository, and updates a test to make sure its only tracked once

@facumenzella facumenzella requested review from vegaro and a team February 10, 2025 14:05
@facumenzella facumenzella merged commit 84172d4 into main Feb 12, 2025
10 checks passed
@facumenzella facumenzella deleted the fix/trackImpression-bug branch February 12, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants