Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issues with finding some locales (ex: zh-Hans and zh-Hant) #4771

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Fixed issues with finding some locales (ex: zh-Hans and zh-Hant) #4771

merged 3 commits into from
Feb 7, 2025

Conversation

joshdholtz
Copy link
Member

Motivation

There were issues with finding locales like zh-Hans and zh-Hant

Description

  1. Attempt to look for the locale identifier as is
  2. If nothing, replace - with _
Example
Simulator Screenshot - iPhone 16 - 2025-02-06 at 22 25 52

@joshdholtz joshdholtz requested review from a team February 7, 2025 04:48
@joshdholtz joshdholtz marked this pull request as ready for review February 7, 2025 05:20
tonidero
tonidero approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshdholtz joshdholtz merged commit e0a5737 into main Feb 7, 2025
10 checks passed
@joshdholtz joshdholtz deleted the paywalls-v2/fix-locale-finding-issues branch February 7, 2025 16:13
@RCGitBot RCGitBot mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonidero tonidero tonidero approved these changes

Assignees
No one assigned
Labels
feat:PaywallV2 pr:fix A bug fix pr:RevenueCatUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshdholtz @tonidero