Fix Gradient Preview on iOS 15 #4762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire-at-will
changed the title
This reverts commit 7c2b8db.
|
@RCGitBot please test |
facumenzella
reviewed
Feb 5, 2025
facumenzella
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
spm-revenuecat-ui-ios-15CI job is currently failing due to compilation issues with theGradientViewpreviews - the preview has more than 10 views inside a container, which SwiftUI doesn't allow:Description
This PR addresses the build issue by abstracting the title and gradient to a private, preview-only
LinearGradientPreviewview, which halves the number of views in theVStack. This doesn't affect the look of the preview:Before Change
After Change
I'm not yet sure why the existing code worked on newer iOS versions but failed in the iOS 15 job - looking into that now