Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revisit environment values for CustomerCenter #4723

Merged
merged 5 commits into from
Jan 29, 2025
Merged

fix: Revisit environment values for CustomerCenter #4723

merged 5 commits into from
Jan 29, 2025

Conversation

facumenzella
Copy link
Contributor

Motivation

This PR revisits every .environment use inside CustomerCenter. The root cause is related to #4704

Description

  1. Order alphabetically environment declarations in each view
  2. Set explicit environment values for each view
  3. Reordered ManageSubscriptionsView moving all navigation modifiers to the same place

I am still thinking what's the best way to test this, or write type-safe code.

@facumenzella facumenzella requested review from vegaro, a team and ajpallares January 28, 2025 12:52
ajpallares
ajpallares approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@ajpallares ajpallares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facumenzella facumenzella merged commit df8dc08 into main Jan 29, 2025
9 of 10 checks passed
@facumenzella facumenzella deleted the fix/environment-values-appearence branch January 29, 2025 16:08
This was referenced Jan 29, 2025
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajpallares ajpallares ajpallares approved these changes

@vegaro vegaro Awaiting requested review from vegaro

Assignees
No one assigned
Labels
feat:Customer Center pr:fix A bug fix pr:RevenueCatUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@facumenzella @ajpallares