[Paywalls V2] Rename paywallFooter to originalTemplatePaywallFooter
#4721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpallares
approved these changes
Jan 28, 2025
tonidero
approved these changes
Jan 28, 2025
JayShortway
approved these changes
Jan 28, 2025
Comment on lines
+117
to
+118
| /// If you are presenting a V1 paywall, this will show the footer of the template you selected. | ||
| /// If you are presenting a V2 paywall, this will show a default footer since V2 paywalls |
There was a problem hiding this comment.
We can keep the V1/V2 stuff here for now imo, but we should be mindful to update this when V2 becomes the default / gets to GA.
This was referenced Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to deprecate
paywallFootersince it has a breaking behavior change for Paywalls V2Description
Deprecating
paywallFooterin favor oforiginalTemplatePaywallFooter