Introduce NavigationOptions for custom navigation and CustomerCenterNavigationLink
#4682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboedo
reviewed
Jan 17, 2025
RevenueCatUI/CustomerCenter/Views/CustomerCenterNavigationLink.swift
Outdated
Show resolved
Hide resolved
facumenzella
commented
Jan 17, 2025
1 build increased size
Paywalls 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| DYLD.String Table | ⬆️ 137.9 kB |
| Code Signature | ⬆️ 5.3 kB |
| DYLD.Exports | ⬆️ 1.8 kB |
| Other | ⬆️ 70.6 kB |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
ajpallares
requested changes
Jan 20, 2025
….swift Co-authored-by: Andy Boedo <[email protected]>
facumenzella
force-pushed
the
fix/navigation-stack-vs-navigationview
branch
from
28d82b6 to
2d26a6d
Compare
vegaro
changed the title
vegaro
changed the title
NavigationOptions for custom navigation and CustomerCenterNavigationLink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR tackles #4311 (comment), introducing
CustomerCenterNavigationOptionsto customize how navigation is handle within theCustomerCenter.Description
Instead of three separate variables I went for a struct, winning in future flexibility. New variables can be added without breaking the API.
It adds some view modifiers to simplify the use of it internally as well.