feat: Add View extension based on CompatibilityNavigationStack #4677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpallares
reviewed
Jan 16, 2025
There was a problem hiding this comment.
This is nice. However, I don't think we need to provide the second method that allows passing a Binding<Item?>, as it is the exact same implementation but only providing a bridge from Binding<Item?> to Binding<Bool>. IMHO, that bridge can be done by the caller of compatibleNavigation. As an alternative, we could provide a convenient bridging from Binding<Item?> to Binding<Bool> independent from this compatibleNavigation method, as it is very common to have this bridging need. WDYT @facumenzella?
facumenzella
force-pushed
the
feat/add-compatibility-nav
branch
from
80d0def to
3154623
Compare
ajpallares
approved these changes
Jan 17, 2025
This was referenced Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To avoid having conditional navigation based on iOS versions everywhere, this adds a wrapper to navigate smoothly. Showing here how it is used