[Paywalls V2] Icon Component #4655
Conversation
1 build increased size
Paywalls 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| DYLD.String Table | ⬆️ 116.4 kB |
| 📝 RevenueCatUI.IconComponentViewModel.IconComponentViewModel | ⬆️ 83.7 kB |
| Code Signature | ⬆️ 16.3 kB |
| DYLD.Exports | ⬆️ 6.0 kB |
| PaywallsTester.debug.dylib | ⬆️ 768 B |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
joshdholtz
force-pushed
the
paywalls-v2/icon-component
branch
from
37b7a01 to
9dcd0d6
Compare
joshdholtz
force-pushed
the
paywalls-v2/icon-component
branch
from
ffb832a to
b0bef46
Compare
| public let svg: String | ||
| public let png: String | ||
| public let heic: String | ||
| public let webp: String |
There was a problem hiding this comment.
Hmm do we need all 4 formats? Could we just keep one?
There was a problem hiding this comment.
Oh yeah 😅 I totally only need heic here! Will remove the rest 👋
| public let padding: Padding? | ||
| public let margin: Padding? | ||
| public let color: ColorScheme | ||
| public let iconBackground: IconBackground? |
There was a problem hiding this comment.
Hmm so the main differences with an ImageComponent are going to be the background + the iconName? (not sure if I missed any) I wonder if we should just reuse ImageComponent...
There was a problem hiding this comment.
And if not for ImageComponent, maybe we can still get away with using ImageComponentView for icons?
There was a problem hiding this comment.
And no overlayColor and also no maskShape 🤷♂️
Could maybe combine them later but I didn't want to think that hard and risk breaking things in the state them I'm in right now 😛
Motivation
New icon component
Description