-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Paywalls V2] Add UIConfig to OfferingsResponse #4628
Conversation
1 build increased size
Paywalls 1.0 (1)
|
Item | Install Size Change |
---|---|
RevenueCat.OfferingsFactory.OfferingsFactory | ⬆️ 81.3 kB |
DYLD.String Table | ⬆️ 55.4 kB |
Code Signature | ⬆️ 10.4 kB |
RCOffering.Objc Metadata | ⬇️ -4.8 kB |
🗑 fr_FR.lproj | ⬇️ -4.1 kB |
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
…ests when we are releasing this soon and this isn't really that dangerous
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool! Just some very minor things only.
Tests/UnitTests/Networking/Responses/UIConfigDecodingTests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for making the changes!
Motivation
Decode more info needed for paywalls
Description
Decode
ui_config
from offerings response for Paywalls V2 to handle: