Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paywalls V2] Add UIConfig to OfferingsResponse #4628

Merged
merged 8 commits into from
Jan 6, 2025

Conversation

joshdholtz
Copy link
Member

Motivation

Decode more info needed for paywalls

Description

Decode ui_config from offerings response for Paywalls V2 to handle:

  • App colors
  • App fonts
  • Localizations (for variables)
  • Backsupport mapping for variables and functions

Copy link

emerge-tools bot commented Jan 2, 2025

1 build increased size

Name Version Download Change Install Change Approval
Paywalls
com.revenuecat.PaywallsTester
1.0 (1) 10.8 MB ⬆️ 117.3 kB (1.09%) 40.3 MB ⬆️ 408.5 kB (1.03%) N/A

Paywalls 1.0 (1)
com.revenuecat.PaywallsTester

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 408.5 kB (1.03%)
Total download size change: ⬆️ 117.3 kB (1.09%)

Largest size changes

Item Install Size Change
RevenueCat.OfferingsFactory.OfferingsFactory ⬆️ 81.3 kB
DYLD.String Table ⬆️ 55.4 kB
Code Signature ⬆️ 10.4 kB
RCOffering.Objc Metadata ⬇️ -4.8 kB
🗑 fr_FR.lproj ⬇️ -4.1 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

…ests when we are releasing this soon and this isn't really that dangerous
Copy link
Member

@JayShortway JayShortway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool! Just some very minor things only.

@joshdholtz joshdholtz requested a review from JayShortway January 4, 2025 13:46
Copy link
Member

@JayShortway JayShortway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making the changes!

@joshdholtz joshdholtz merged commit 9ef833b into main Jan 6, 2025
10 checks passed
@joshdholtz joshdholtz deleted the paywalls-v2/ui-config-api branch January 6, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants