Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Comment to StoreKit2ObserverModePurchaseDetectorTests #4614

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

fire-at-will
Copy link
Contributor

@fire-at-will fire-at-will commented Dec 20, 2024

Motivation

I found myself wondering why we were running the tests in StoreKit2ObserverModePurchaseDetectorTests on iOS 15 since we only support purchasing with SK2 on iOS 16+, so I added this comment to remind future me and other folks of why we run these tests on iOS 15.

@fire-at-will fire-at-will marked this pull request as ready for review December 20, 2024 12:46
@fire-at-will fire-at-will requested review from MarkVillacampa and a team December 20, 2024 13:17
@fire-at-will fire-at-will enabled auto-merge (squash) December 20, 2024 13:46
@fire-at-will fire-at-will merged commit a61b32f into main Dec 20, 2024
10 checks passed
@fire-at-will fire-at-will deleted the add-comment-to-observer-mode-tests branch December 20, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants