Dont show refund cancelled message when user cancels refund #4587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when the user cancels a refund, we show the following message on the SubscriptionDetailsView screen under the "Refund Status" message:
This message is a little confusing because it implies that a refund was created and was then cancelled, when one was never created in the first place. When I saw the message, my first thought was, "do I have the money, or does the developer?".
Description
This PR modifies the behavior so that the "Refund Status" section doesn't display at all when the user dismisses the refund screen without creating a refund, since the user already knows that they cancelled it.
The PR doesn't remove the
refundCanceledlocalized string in case we need it in the future here or on another platform.