Support toggling update warnings & show update in restore flow #4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnCustomerToUpdate is true
fire-at-will
commented
Dec 11, 2024
| @@ -117,6 +125,13 @@ import RevenueCat | |||
| func loadCustomerCenterConfig() async { | |||
| do { | |||
| self.configuration = try await Purchases.shared.loadCustomerCenter() | |||
| if let productId = configuration?.productId { | |||
There was a problem hiding this comment.
Moved this from the AppUpdateWarningView to centralize the logic into one place since it's also used in the restore flow now
fire-at-will
changed the title
vegaro
approved these changes
Dec 11, 2024
| private(set) var onUpdateAppClick: (() -> Void)? | ||
|
|
||
| /// Whether or not the Customer Center should warn the customer that they're on an outdated version of the app. | ||
| var shouldShowAppUpdateWarnings: Bool { |
There was a problem hiding this comment.
I think this can be private(var)
There was a problem hiding this comment.
I don't think it can - since it's used in other views it needs to be non-private and it can't be made private(set) because it's a computed property
Tests/RevenueCatUITests/CustomerCenter/CustomerCenterViewModelTests.swift
Outdated
Show resolved
Hide resolved
| @@ -132,6 +132,7 @@ struct CustomerCenterConfigResponse { | |||
| struct Support { | |||
|
|
|||
| let email: String | |||
| let shouldWarnCustomerToUpdate: Bool? | |||
There was a problem hiding this comment.
is this nullable in the response?
There was a problem hiding this comment.
Yeah, some configurations made from before the field was introduced don't have it. It's also nullable in the dashboard!
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Support.shouldWarnCustomerToUpdateboolean from the backend to determine if update warnings should be displayed to the userAlertto aConfirmationDialogsince we have up to 3 actions that a user can take, andAlertonly supports a max of 2Support.shouldWarnCustomerToUpdateis enabled, and the user is an old app versionWarning
This PR is a breaking change from a UI standpoint because it now requires
Support.shouldWarnCustomerToUpdateto be set for the AppUpdateWarningView to be displayed. This hasn't been enabled by default yet, so most people using Customer Center so far will need to enable the checkbox to see the warnings.Follow-Up Actions
Screenshots
Restore Flow
iOS
iPadOS
macOS (Designed for iPad)