PurchaseButtonComponent is now just a container/stack like ButtonComponent #4415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdholtz
changed the base branch from
main
to
paywalls-components/remove-package-group
JayShortway
reviewed
Oct 28, 2024
RevenueCatUI/Templates/Components/Button/ButtonComponentView.swift
Outdated
Show resolved
Hide resolved
Base automatically changed from
paywalls-components/remove-package-group
to
main
October 31, 2024 15:46
joshdholtz
deleted the
paywalls-components/make-purchase-button-a-stack
branch
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make
PurchaseButtonComponentmore flexible by just letting it be a stack (likeButtonComponent)Description
Removed all properties and just gave it a
stack: StackComponentproperty