Create CustomerCenterEvent
#4392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegaro
force-pushed
the
https/linear.app/revenuecat/issue/SDK-3607/create-customer-center-open-event
branch
from
79779b0 to
72e8bfd
Compare
Base automatically changed from
https/linear.app/revenuecat/issue/SDK-3607/create-customer-center-open-event
to
main
November 5, 2024 14:23
vegaro
force-pushed
the
create-customer-center-event
branch
3 times, most recently
from
9cb79d7 to
3d5acba
Compare
vegaro
force-pushed
the
create-customer-center-event
branch
from
e260a16 to
503cea5
Compare
vegaro
force-pushed
the
create-customer-center-event
branch
from
51c1c3f to
6a7d6e8
Compare
tonidero
approved these changes
Nov 29, 2024
Sources/CustomerCenter/Events/EventsRequest+CustomerCenter.swift
Outdated
Show resolved
Hide resolved
Sources/CustomerCenter/Events/EventsRequest+CustomerCenter.swift
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| func track(paywallEvent: PaywallEvent) async { | ||
| guard let event: StoredEvent = .init(event: paywallEvent, | ||
| func track(featureEvent: FeatureEvent) async { |
There was a problem hiding this comment.
Can go in a different PR, but if this class now accepts other event types, we should also rename PaywallEventsManager to FeatureEventsManager or something like that.
There was a problem hiding this comment.
Will come in a different PR but yes, good point
This was referenced Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CustomerCenterEventwith valueimpressionapp_session_idisSandboxinPurchases