Models the Action for the ButtonComponent #4353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponents/button-component-2 # Conflicts: # RevenueCatUI/Templates/Components/Button/ButtonComponentView.swift # Sources/Paywalls/Components/PaywallButtonComponent.swift
JayShortway
commented
Oct 4, 2024
RevenueCatUI/Templates/Components/Button/ButtonComponentView.swift
Outdated
Show resolved
Hide resolved
JayShortway
commented
Oct 4, 2024
JayShortway
commented
Oct 4, 2024
JayShortway
commented
Oct 7, 2024
JayShortway
commented
Oct 7, 2024
…omponents/button-component-2
…omponents/button-component-2
…omponents/button-component-2
…omponents/button-component-2
joshdholtz
approved these changes
Oct 14, 2024
Comment on lines
+42
to
+45
| func onClick() { | ||
| // swiftlint:disable:next todo | ||
| // TODO Handle the configured Action. | ||
| } |
There was a problem hiding this comment.
I mentioned this in a PR further down the chain but I would probably name this to performAction()since it could be a click or a tap 😇 Just a nit of mine 😅
There was a problem hiding this comment.
Oh yes, great point. I'll rename it in the other PR, since this function is moved in that PR as well.
Base automatically changed from
paywalls-components/button-component-1
to
main
October 14, 2024 10:13
# Conflicts: # RevenueCatUI/Templates/Components/Button/ButtonComponentView.swift # RevenueCatUI/Templates/Components/Button/ButtonComponentViewModel.swift # Sources/Paywalls/Components/PaywallButtonComponent.swift
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says. No implementation whatsoever. Will do that in follow-ups.