Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paywall Components Initial Commit #4224
Paywall Components Initial Commit #4224
Changes from 55 commits
9f4419a
7d46bb2
1dd97de
b70eef9
f3bd65a
31af70c
ddc22d5
2a7b7a4
bf3ce3d
5fd18f9
84ac29a
a73c42d
381b96b
9c754ae
c2f461b
232f392
39d87fe
f048085
4f3784e
380a8e6
6ede294
38c11e3
714f483
3574199
a35aa7c
4fb295b
5622854
edd55f5
77b3468
0888b94
495b5fd
6730f0d
bdb3d80
c8a4460
52f2902
a05fb2b
1bad03d
86a9f36
3a60e57
eab0c8d
72ad780
ad1dd81
833ae17
de4fe87
80e0e81
56a7175
8c291b5
61727a8
7d23d2f
742fc32
1062ab7
bb3bf8c
dc4fdb4
1553917
95f4056
ee0ffbc
1614d80
7222042
b5ff52c
48e50ac
5fa016d
dba53ef
1a5961b
76f1ddb
116dc9a
8d0bbc0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewer note: this will be reworked in future PR with proper loading and validation ☝️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Not for this PR]
I was about to comment that we should move this to one of the strings files, and then I realized that that's part of the main SDK. Maybe we should start thinking about extracting a
Core
framework to be used by both RevenueCat and RevenueCatUI (we actually used to have one a few years back)