Paywalls components/file split #4200
Conversation
and removed try! from PaywallColor, as per linter
|
Left in the Tiers Toggle and Tiers Selector because they are used by Tiers. This may be revisited in the future. |
| @@ -0,0 +1,198 @@ | |||
| // | |||
| // File.swift | |||
There was a problem hiding this comment.
This is how you can tell how much of a POC this was 😛
| func getLocalization(_ locale: Locale, _ displayString: DisplayString) -> String { | ||
| if let found = displayString.value[locale.identifier] { | ||
| return found | ||
| } | ||
|
|
||
| return displayString.value.values.first! | ||
| } |
There was a problem hiding this comment.
Note for later: this will get replaced with proper localization lookup... this was very proof of concept
| var landscapeLeftComponents: [PaywallComponent] { | ||
| return self.components.filter { component in | ||
| guard let displayPreferences = component.displayPreferences else { | ||
| return true | ||
| } | ||
| return displayPreferences.contains(.landscapeLeft) | ||
| } | ||
| } | ||
|
|
||
| var landscapeRightComponents: [PaywallComponent] { | ||
| return self.components.filter { component in | ||
| guard let displayPreferences = component.displayPreferences else { | ||
| return true | ||
| } | ||
| return displayPreferences.contains(.landscapeRight) | ||
| } | ||
| } | ||
|
|
||
| var portraitComponents: [PaywallComponent] { | ||
| return self.components.filter { component in | ||
| guard let displayPreferences = component.displayPreferences else { | ||
| return true | ||
| } | ||
| return displayPreferences.contains(.portrait) | ||
| } | ||
| } |
There was a problem hiding this comment.
Note for later: this was done mainly for proof of conept. We will be having more discussions about how to properly handle landscape
| @@ -98,16 +79,6 @@ public enum PaywallComponent: Decodable, Sendable, Hashable, Equatable { | |||
| return component.displayPreferences | |||
| case .image(let component): | |||
| return component.displayPreferences | |||
| case .video(let component): | |||
There was a problem hiding this comment.
This whole displayPreferences could honestly probably get deleted. This was for the portrait/landscape POC that we will probably end up rethinking Its just a bit messy ATM so I'm find getting rid of this 👍
| @@ -125,16 +96,6 @@ public enum PaywallComponent: Decodable, Sendable, Hashable, Equatable { | |||
| return component.focusIdentifiers | |||
| case .image(let component): | |||
| return component.focusIdentifiers | |||
| case .video(let component): | |||
| return component.focusIdentifiers | |||
There was a problem hiding this comment.
Same with this! This was for game controller POC so this whole focusIdentifier thing can get deleted 👋
There was a problem hiding this comment.
Ya I was thinking that, will do.
Adds a feature flag that allows us to merge the paywalls component to main but keep it out of any compiled packages. Avoids the pains of a long-running feature branch.
jamesrb1
merged commit b70eef9
into
paywalls-components/initial-merge
Removes code we won't be using for some time and splits up some large files into component files.