Always call readyForPromotedProduct on the main actor

RevenueCat · Dec 16, 2024 · e78c56d · e78c56d
1 parent 793b6f6
commit e78c56d
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 6 deletions.
diff --git a/Sources/Purchasing/Purchases/Purchases.swift b/Sources/Purchasing/Purchases/Purchases.swift
@@ -1597,7 +1597,13 @@ extension Purchases: PurchasesOrchestratorDelegate {
      */
     func readyForPromotedProduct(_ product: StoreProduct,
                                  purchase startPurchase: @escaping StartPurchaseBlock) {
-        self.delegate?.purchases?(self, readyForPromotedProduct: product, purchase: startPurchase)
+        OperationDispatcher.dispatchOnMainActor {
+            self.delegate?.purchases?(
+                self,
+                readyForPromotedProduct: product,
+                purchase: startPurchase
+            )
+        }
     }
 
 #if os(iOS) || targetEnvironment(macCatalyst) || VISION_OS

diff --git a/Tests/UnitTests/Purchasing/Purchases/PurchasesDeferredPurchasesTests.swift b/Tests/UnitTests/Purchasing/Purchases/PurchasesDeferredPurchasesTests.swift
@@ -42,6 +42,12 @@ class PurchaseDeferredPurchasesTests: BasePurchasesTests {
                                                                shouldAddStorePayment: payment,
                                                                for: self.product)
 
+        waitUntil { completed in
+            if self.purchasesDelegate.makeDeferredPurchase != nil {
+                completed()
+            }
+        }
+
         expect(self.purchasesDelegate.makeDeferredPurchase).toNot(beNil())
         expect(self.storeKit1Wrapper.payment).to(beNil())
 
@@ -59,6 +65,12 @@ class PurchaseDeferredPurchasesTests: BasePurchasesTests {
                                                                shouldAddStorePayment: payment,
                                                                for: self.product)
 
+        waitUntil { completed in
+            if self.purchasesDelegate.makeDeferredPurchase != nil {
+                completed()
+            }
+        }
+
         expect(self.purchasesDelegate.makeDeferredPurchase).toNot(beNil())
         expect(self.storeKit1Wrapper.payment).to(beNil())
 
@@ -87,7 +99,7 @@ class PurchaseDeferredPurchasesTests: BasePurchasesTests {
                                                                shouldAddStorePayment: payment,
                                                                for: self.product)
 
-        expect(self.purchasesDelegate.promoProduct) == StoreProduct(sk1Product: self.product)
+        expect(self.purchasesDelegate.promoProduct).toEventually(equal(StoreProduct(sk1Product: self.product)))
     }
 
     func testShouldAddStorePaymentReturnsFalseForNilProductIdentifier() throws {
@@ -177,10 +189,9 @@ class PurchaseDeferredPurchasesSK2Tests: BasePurchasesTests {
             for: self.product
         )
 
-        expect(self.purchasesDelegate.makeDeferredPurchase).toNot(beNil())
-
-        expect(self.purchasesDelegate.promoProduct) == StoreProduct(sk1Product: self.product)
-        expect(self.purchasesDelegate.makeDeferredPurchase).toNot(beNil())
+        expect(self.purchasesDelegate.makeDeferredPurchase).toEventuallyNot(beNil())
+        expect(self.purchasesDelegate.promoProduct).toEventually(equal(StoreProduct(sk1Product: self.product)))
+        expect(self.purchasesDelegate.makeDeferredPurchase).toEventuallyNot(beNil())
     }
 
 }