Dismiss PaywallFragment after PaywallActivity is dismissed #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
commented
Jan 17, 2025
| @@ -94,6 +96,14 @@ internal class PaywallFragment : Fragment(), PaywallResultHandler { | |||
| override fun onCreate(savedInstanceState: Bundle?) { | |||
| super.onCreate(savedInstanceState) | |||
|
|
|||
| // This should normally never happen, but just in case, we don't want to try to present the paywall | |||
| // if the SDK is not configured. | |||
| if (!Purchases.isConfigured) { | |||
There was a problem hiding this comment.
I don't think this is needed... But I added it as a failsafe, in case we're missing any more cases.
This was referenced Jan 17, 2025
tonidero
pushed a commit
that referenced
this pull request
Jan 17, 2025
**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * Dismiss PaywallFragment after PaywallActivity is dismissed (#1016) via Toni Rico (@tonidero) ### 🔄 Other Changes * Bump lefthook from 1.10.4 to 1.10.7 (#1015) via dependabot[bot] (@dependabot[bot]) * Bump lefthook from 1.9.2 to 1.10.4 (#1012) via dependabot[bot] (@dependabot[bot])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not dismissing the
PaywallFragmentafter thePaywallActivitywas closed. This caused some crashes like: RevenueCat/purchases-flutter#1090.Repro steps were: