Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-1757] Handle new backend error codes that may show in the redemption endpoint #1987

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

tonidero
Copy link
Contributor

Description

Currently these error codes would display in the API as "UnknownBackendError". This performs some better processing of these error codes.

@tonidero tonidero requested review from a team December 16, 2024 10:53
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.89%. Comparing base (bca0771) to head (2a23dde).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...n/kotlin/com/revenuecat/purchases/common/errors.kt 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1987      +/-   ##
==========================================
- Coverage   81.90%   81.89%   -0.02%     
==========================================
  Files         260      260              
  Lines        8505     8511       +6     
  Branches     1227     1227              
==========================================
+ Hits         6966     6970       +4     
- Misses       1039     1041       +2     
  Partials      500      500              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonidero tonidero merged commit e7c0c3e into main Dec 17, 2024
11 checks passed
@tonidero tonidero deleted the handle-new-backend-error-codes branch December 17, 2024 09:14
tonidero pushed a commit that referenced this pull request Dec 19, 2024
**This is an automatic release.**

## RevenueCat SDK
### 📦 Dependency Updates
* Bump fastlane from 2.225.0 to 2.226.0 (#1973) via dependabot[bot]
(@dependabot[bot])
* Bump fastlane-plugin-revenuecat_internal from `3b1e7cf` to `4ee8579`
(#1980) via dependabot[bot] (@dependabot[bot])

### 🔄 Other Changes
* [Paywalls V2] Fixes previews of `ButtonComponentView`,
`StackComponentView` and `TextComponentView` (#1992) via JayShortway
(@JayShortway)
* [Paywalls V2] Adds a `FLAG_PAYWALL_COMPONENTS` build flag (#1990) via
JayShortway (@JayShortway)
* [Paywalls V2] Moves more state to `PaywallState` (#1988) via
JayShortway (@JayShortway)
* [PaywallsV2] Improve `ButtonComponentView` to handle disabling the
button and add `PurchasePackage` action (#1984) via Toni Rico
(@tonidero)
* [Paywalls V2] `TextComponentStyle` no longer needs a Composable
context (#1986) via JayShortway (@JayShortway)
* Make web redemption link APIs stable (#1985) via Toni Rico (@tonidero)
* [WEB-1757] Handle new backend error codes that may show in the
redemption endpoint (#1987) via Toni Rico (@tonidero)
* [Paywalls V2] Stack background, borders and shadows update depending
on the theme (#1982) via JayShortway (@JayShortway)
* [Paywalls V2] Fixes `TextComponentView`'s font size (#1981) via
JayShortway (@JayShortway)
* [Paywalls V2] Various minor fixes (#1979) via JayShortway
(@JayShortway)
* [Paywalls V2] Adds support to PaywallsTester (#1978) via JayShortway
(@JayShortway)
* [Paywalls V2] Adds `PaywallComponentsData` to `Offering` (#1977) via
JayShortway (@JayShortway)
* Parse web redemption link strings more defensively (#1976) via Toni
Rico (@tonidero)
* Add web redemption parse method for strings to support hybrids (#1972)
via Toni Rico (@tonidero)

Co-authored-by: revenuecat-ops <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants