[Paywalls V2] LocalizationKey is an inline value class now.
#1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by ColorInfo as well.
📸 Snapshot Test74 unchanged
🛸 Powered by Emerge Tools |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pw2-paywallcomponentsdata #1936 +/- ##
=============================================================
- Coverage 81.93% 81.89% -0.05%
=============================================================
Files 260 260
Lines 8410 8449 +39
Branches 1215 1226 +11
=============================================================
+ Hits 6891 6919 +28
- Misses 1021 1032 +11
Partials 498 498 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
joshdholtz
approved these changes
Nov 25, 2024
Comment on lines
+19
to
+21
| @Serializable | ||
| @JvmInline | ||
| internal value class LocalizationKey(val value: String) |
There was a problem hiding this comment.
I totally know what a @JvmInline is... yup yup yup 😅
There was a problem hiding this comment.
Haha, this instructs the Kotlin compiler to make it a value class from a Java perspective.
# Conflicts: # purchases/src/main/kotlin/com/revenuecat/purchases/paywalls/components/Localization.kt # purchases/src/test/java/com/revenuecat/purchases/paywalls/components/ComponentsConfigTests.kt # purchases/src/test/java/com/revenuecat/purchases/paywalls/components/PaywallComponentsDataTests.kt
This was referenced Nov 28, 2024
JayShortway
pushed a commit
that referenced
this pull request
Dec 2, 2024
**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * Uses `Sequence` instead of `Stream` to avoid errors due to unavailable Java 8 APIs (#1943) via JayShortway (@JayShortway) ### 🔄 Other Changes * Increase integration test timeout (#1946) via Toni Rico (@tonidero) * Removes `@RequiresApi(N)` from `FileHelper` and related classes (#1944) via JayShortway (@JayShortway) * [Paywalls V2] Minimizes Java API (#1942) via JayShortway (@JayShortway) * [Paywalls V2] Makes `TextComponent` public (#1939) via JayShortway (@JayShortway) * Introduces an `@InternalRevenueCatAPI` annotation (#1938) via JayShortway (@JayShortway) * [Paywalls V2] Moves any non-component file to a new `common` package. (#1937) via JayShortway (@JayShortway) * [Paywalls V2] `LocalizationKey` is an inline value class now. (#1936) via JayShortway (@JayShortway) * [Paywalls V2] Adds `PaywallComponentsData` (#1935) via JayShortway (@JayShortway) * [Paywalls V2] Adds `StickyFooterComponent` (#1934) via JayShortway (@JayShortway) * [Paywalls V2] Adds `PurchaseButtonComponent` (#1933) via JayShortway (@JayShortway) * [Paywalls V2] Adds `PackageComponent` (#1932) via JayShortway (@JayShortway) * Ensure the correct error message is shown when failing to open a Uri in paywalls (#1922) via JayShortway (@JayShortway) * [Paywalls V2] Adds `ButtonComponent` (#1931) via JayShortway (@JayShortway) * [Paywalls V2] Adds `StackComponent` (#1930) via JayShortway (@JayShortway) * [Paywalls V2] Adds `ComponentOverrides` (#1929) via JayShortway (@JayShortway) * [Paywalls V2] Adds `ImageComponent` (#1928) via JayShortway (@JayShortway) * [Paywalls V2] Adds `TextComponent` (#1927) via JayShortway (@JayShortway) * [Paywalls V2] Adds all enum properties (#1926) via JayShortway (@JayShortway) * [Paywalls V2] Adds `SizeConstraints`, `Size`, `Padding` and `Shadow` properties (#1925) via JayShortway (@JayShortway) * [Paywalls V2] Adds `CornerRadiuses`, `Shape` and `MaskShape` properties (#1924) via JayShortway (@JayShortway) * [Paywalls V2] Adds `ImageUrls` and `ColorInfo` properties (#1923) via JayShortway (@JayShortway) Co-authored-by: revenuecat-ops <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small adjustment to the
LocalizationKeytype, making it an inline value class, giving us a bit more type safety without the runtime cost.LocaleIdis already an inline value class.