Fix changelog generation when there are commits without PRs (#73)

* Fix changelog generation when there are commits without PRs * Fix test
RevenueCat · Dec 12, 2024 · 4ee8579 · 4ee8579
1 parent 3b1e7cf
commit 4ee8579
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/lib/fastlane/plugin/revenuecat_internal/helper/versioning_helper.rb b/lib/fastlane/plugin/revenuecat_internal/helper/versioning_helper.rb
@@ -110,8 +110,7 @@ def self.auto_generate_changelog(repo_name, github_token, rate_limit_sleep, incl
             UI.important("Cannot find pull request associated to #{sha}. Using commit information and adding it to the Other section")
             message = commit["commit"]["message"]
             name = commit["commit"]["author"]["name"]
-            username = commit["author"]["login"]
-            line = "* #{message} via #{name} (@#{username})"
+            line = "* #{message} via #{name}"
             changelog_sections[:other].push(line)
           else
             UI.user_error!("Cannot generate changelog. Multiple commits found for #{sha}")

diff --git a/spec/helper/versioning_helper_spec.rb b/spec/helper/versioning_helper_spec.rb
@@ -447,7 +447,7 @@
         nil
       )
       expect(changelog).to eq("### 🔄 Other Changes\n" \
-                              "* Updating great support link via Miguel José Carranza Guisado (@MiguelCarranza)")
+                              "* Updating great support link via Miguel José Carranza Guisado")
     end
 
     def mock_native_releases