Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating warning message for previewing paywalls #198

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

michaelAtRC
Copy link
Contributor

Motivation / Description

I have had a couple of tickets where users reach out with preview data in their paywalls saying the data is inaccurate. While this isn't a big change, making the note a warning might help better inform users that this isn't expected to be their real data.

Changes introduced

Make note a warning message

Copy link

Preview this PR here: https://dev-docs.revenuecat.com/pr-198/

@michaelAtRC michaelAtRC requested a review from codykerns April 18, 2024 21:59
@michaelAtRC michaelAtRC marked this pull request as ready for review April 18, 2024 23:12
@michaelAtRC michaelAtRC requested a review from a team April 25, 2024 17:48
Copy link
Contributor

@Jethro87 Jethro87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning opening and closing tags should be on separate lines:

:::warning
message
:::

I think that's what causing this:
Screenshot 2024-04-25 at 4 47 24 PM

@michaelAtRC
Copy link
Contributor Author

Changed @Jethro87

@michaelAtRC michaelAtRC merged commit 5fb52b3 into main Apr 30, 2024
3 checks passed
@michaelAtRC michaelAtRC deleted the michaelAtRC-patch-1 branch April 30, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants