Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concurrency problems in PlayCollect #164

Closed
hrosa opened this issue May 31, 2016 · 1 comment
Closed

Concurrency problems in PlayCollect #164

hrosa opened this issue May 31, 2016 · 1 comment
Assignees
@hrosa
Labels
bug High-Priority
Milestone
5.0.0

Comments

@hrosa
Copy link
Contributor

hrosa commented May 31, 2016

NPE when PlayCollect operation is canceled prematurely by DTMF detector.

2016-05-31 03:26:48,167 INFO PlayCollect (mobicents/ivr/31) Prompt phase terminated, start collect phase
2016-05-31 03:26:49,066 INFO AudioPlayerImpl (mobicents/ivr/35) End of file reached
2016-05-31 03:26:49,066 INFO PlayCollect (mobicents/ivr/35) Processing player next with url - https://10.172.67.3:443/restcomm/cache/ACae6e420f425248d6a26948c17a9e2acf/7ed89118a42127adb7c70b4536b5d0e33ff61f4281ec232b99157ef791708bfe.wav
2016-05-31 03:26:50,186 INFO EventBuffer Receive 2 tone
2016-05-31 03:26:50,186 INFO AudioPlayerImpl (mobicents/ivr/14) End of file reached
2016-05-31 03:26:50,186 INFO PlayCollect (mobicents/ivr/14) Tone '2' has been detected
2016-05-31 03:26:50,186 INFO PlayCollect (mobicents/ivr/14) Processing player next with url - https://10.172.67.3:443/restcomm/cache/ACae6e420f425248d6a26948c17a9e2acf/7ed89118a42127adb7c70b4536b5d0e33ff61f4281ec232b99157ef791708bfe.wav
2016-05-31 03:26:50,186 INFO PlayCollect (mobicents/ivr/14) Tone '2' has been detected: prompt phase interrupted
2016-05-31 03:26:50,187 INFO DetectorImpl (mobicents/ivr/14) (detector) Delivered '2' tone
2016-05-31 03:26:50,191 ERROR Task Could not execute task 2: null
java.lang.NullPointerException
at org.mobicents.media.server.mgcp.pkg.au.PlayCollect.next(PlayCollect.java:387)
at org.mobicents.media.server.mgcp.pkg.au.PlayCollect.access$500(PlayCollect.java:62)
at org.mobicents.media.server.mgcp.pkg.au.PlayCollect$PromptHandler.process(PlayCollect.java:527)
at org.mobicents.media.server.mgcp.pkg.au.PlayCollect$PromptHandler.process(PlayCollect.java:503)
at org.mobicents.media.server.spi.listener.Listeners.dispatch(Listeners.java:117)
at org.mobicents.media.server.impl.resource.mediaplayer.audio.AudioPlayerImpl.completed(AudioPlayerImpl.java:210)
at org.mobicents.media.server.impl.AbstractSource$Worker.perform(AbstractSource.java:442)
at org.mobicents.media.server.scheduler.Task.run(Task.java:122)
at org.mobicents.media.server.scheduler.PriorityQueueScheduler$WorkerThread.run(PriorityQueueScheduler.java:424)
@hrosa hrosa added this to the 4.2.0 milestone May 31, 2016
@hrosa hrosa self-assigned this Jun 1, 2016
hrosa added a commit that referenced this issue Jun 1, 2016
@hrosa
#164 Code formatting. Protected logging statements.
846c70a
hrosa added a commit that referenced this issue Jun 2, 2016
@hrosa
#164 Added synchronized blocks in strategic places to avoid concurren…
b6126bf 
…cy issues.
@hrosa
Copy link
Contributor Author

hrosa commented Jun 2, 2016

Load tests no longer show NPE traces.

hrosa added a commit that referenced this issue Jun 3, 2016
@hrosa
#164 Added synchronized blocks to prevent further NPE when playing ne…
edebfdc 
…xt, previous or current announcement.

#167 Operation Failed (of) events now containa reason code (rc) instead of logging the exception message.
@hrosa hrosa added testing and removed in progress labels Jun 3, 2016
@hrosa hrosa closed this as completed Jun 3, 2016
@hrosa hrosa removed the testing label Jun 3, 2016
hrosa added a commit that referenced this issue Jun 3, 2016
@hrosa
patches #164 Added synchronized blocks to prevent further NPE when pl…
2d060c1 
…aying next, previous or current announcement.

patches #167 Operation Failed (of) events now containa reason code (rc) instead of logging the exception message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hrosa hrosa

Labels
bug High-Priority
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
1 participant
@hrosa