Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to reload configuration if config file changes #69

Closed
yarikoptic opened this issue Jan 8, 2024 · 1 comment
Closed
Assignees

Comments

@yarikoptic
Copy link
Member

while dealing with "deployed" solution, trying to avoid interference with already ongoing data collection, it would be great if we could make it to reload config file to e.g. discover / use adjusted ffmpeg options. I guess one way could be just to make it react to some signal (HUP) and do reload of config then. Another, to monitor config file (remember mtime upon read, check mtime later if changes -- reload).

@vmdocua vmdocua mentioned this issue Jan 9, 2024
yarikoptic added a commit that referenced this issue Feb 2, 2024
* commit '61edd2954ec555d06fcaaa8243060cb1fbbaefc6': (24 commits)
  ScreenCapture added "interval_ms" options (work in progress).
  ScreenCapture separate snapshots subdirectory for each capture session (work in progress).
  ScreenCapture options in config.yaml (work in progress).
  ScreenCapture interactive process in separate thread (work in progress).
  ScreenCapture interactive process in separate thread (work in progress).
  Cosmetics in help message.
  Fix Install build dependencies error
  Fix Install build dependencies error
  ScreenCapture prototype (work in progress).
  Audio device optional configuration, enabled in VideoCapture and disabled in ScreenCapture #66
  Entry point moved to main.cpp in VideoCapture and ScreenCapture projects #61
  Normalize headers in CaptureLib/VideoCapture/ScreenCapture #61
  Refactored ScreenCapture to reuse basic app code from reprostim::CaptureApp class #61
  Refactored VideoCapture, basic app code moved to common reprostim::CaptureApp class #61
  Moved common/shared C++ code to reprostim::CaptureLib library #61
  Make ffmpeg execution processed by background thread rather than system() command #68
  Make it possible to reload configuration if config file changes #69
  Upon interruption (Ctrl-C) make it to exit gracefully #70
  ScreenCapture project basis structure setup and CaptureLib work-in-progress
  Ported project to CMake-basis and created capturelib library with common capture functionality #61
  ...

 Conflicts:
	Capture/videocapture/config.yaml -- Vadim has added --flush_packets 1 for ffmpeg options and removed pix_fmt.  I took his version entirely -- yet to do changes in deployment
@vmdocua
Copy link
Collaborator

vmdocua commented Feb 18, 2024

Implemented in PR #71

@vmdocua vmdocua closed this as completed Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants