Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case insensitive search #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dangilkerson
Copy link

Partial fix for Fuzzy matching #13

Will do fuzzy searching next

Partial fix for Fuzzy matching Remeic#13
@ashnegi
Copy link

ashnegi commented Sep 23, 2020

Please approve

@Remeic
Copy link
Owner

Remeic commented Oct 2, 2020

Hi @dangilkerson, thanks for opening this PR, any contribution is very fundamental for us.
There is a problem with this PR, replacing 'g' with 'gi' the insensitive search is now enabled and can't turned off.

I suggest to refactor the option for a case sensitive search and allow users to choose the best option for them.
For any suggestion or doubt don't hesitate to contact us

1 similar comment
@Remeic
Copy link
Owner

Remeic commented Oct 2, 2020

Hi @dangilkerson, thanks for opening this PR, any contribution is very fundamental for us.
There is a problem with this PR, replacing 'g' with 'gi' the insensitive search is now enabled and can't turned off.

I suggest to refactor the option for a case sensitive search and allow users to choose the best option for them.
For any suggestion or doubt don't hesitate to contact us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants