Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add palladium alloys #264

Merged

Conversation

natethegreatINL
Copy link
Contributor

I added a new class of material, Palladium alloys. Of that class, I added two materials, Pd-Cu and Pd-Ag. I also added one new property to normal Palladium. This branch passed all the tests.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (6464902) 98.70% compared to head (46f1c82) 98.72%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   98.70%   98.72%   +0.01%     
==========================================
  Files          75       76       +1     
  Lines        1781     1800      +19     
==========================================
+ Hits         1758     1777      +19     
  Misses         23       23              
Files Changed Coverage Δ
h_transport_materials/material.py 98.16% <100.00%> (+0.05%) ⬆️
..._transport_materials/property_database/__init__.py 100.00% <100.00%> (ø)
...transport_materials/property_database/palladium.py 100.00% <100.00%> (ø)
...rt_materials/property_database/palladium_copper.py 100.00% <100.00%> (ø)
...terials/property_database/pdag/palladium_silver.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @natethegreatINL thanks for this contribution!

We already have some PdAg data in HTM.
Does this overlap with these entries? If not, maybe we could use the new PalladiumAlloy class for those as well.

I'll have a look at the properties.

Copy link
Owner

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

Copy link
Owner

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more comments about Piper's property

@RemDelaporteMathurin RemDelaporteMathurin merged commit a0aa6a8 into RemDelaporteMathurin:main Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants