-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add palladium alloys #264
Add palladium alloys #264
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
==========================================
+ Coverage 98.70% 98.72% +0.01%
==========================================
Files 75 76 +1
Lines 1781 1800 +19
==========================================
+ Hits 1758 1777 +19
Misses 23 23
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @natethegreatINL thanks for this contribution!
We already have some PdAg data in HTM.
Does this overlap with these entries? If not, maybe we could use the new PalladiumAlloy class for those as well.
I'll have a look at the properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some more comments about Piper's property
I added a new class of material, Palladium alloys. Of that class, I added two materials, Pd-Cu and Pd-Ag. I also added one new property to normal Palladium. This branch passed all the tests.