fix: make number default to float if format is float or double

[kennethaasan]

What/Why/How?

Schemas with type number should always be sampled with a double or float, and not an integer. According to the OpenAPI spec, the format of a number is either a double or a float.

Reference

https://spec.openapis.org/oas/v3.1.0#data-types

Testing

Screenshots (optional)

Check yourself

• Code is linted
• Tested
• All new/updated code is covered with tests

Security

• Security impact of change has been considered
• Code follows company security practices and guidelines

[kennethaasan]

@RomanHotsiy, is this something you can approve?

[RomanHotsiy]

Oh, I'm not sure. It seems like a big change. Too many real-life usages use number for integers.

I don't think we need to change it.

[kennethaasan]

I can understand that. What if I add another check for format === "float" || format === "double"? Then it should definitely default to a floating number.

[RomanHotsiy]

@kennethaasan yes, totally agree here.

[kennethaasan]

Great! Please check now.

[kennethaasan]

@RomanHotsiy, please review again. I would appreciate this getting merged soon!

[RomanHotsiy]

Thanks @kennethaasan !

[RomanHotsiy]

Just published 1.4.0.

@AlexVarchuk please, upgrade Redoc to this version when you have chance. Thanks!

[kennethaasan]

FYI @magicmatatjahu @derberg for asyncapi-react