Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish CI. #324

Merged
merged 2 commits into from
May 4, 2023
Merged

Conversation

MeirShpilraien
Copy link
Collaborator

@MeirShpilraien MeirShpilraien commented May 4, 2023

Added extra-traits feature to syn dependency so we will get the Debug trait implementation.

@MeirShpilraien MeirShpilraien requested a review from iddm May 4, 2023 04:59
@MeirShpilraien
Copy link
Collaborator Author

@iddm
Copy link
Collaborator

iddm commented May 4, 2023

I wonder how has it ever been compiled? By the way, the syn::Ident has Debug, and the ItemFn has Debug when the extra-traits feature is used. As long as it is useful, I would have it. When I was writing the proc-macro, I was also using the Debug trait's output as it was helpful.

@MeirShpilraien
Copy link
Collaborator Author

I wonder how has it ever been compiled

Yes I also wonder the same thing. If you compile the crate itself it does not compile. But I guess we never really tried it and we just use it on the redismodule-rs crate which does seem to work.

@MeirShpilraien MeirShpilraien merged commit 02c1ab3 into master May 4, 2023
@MeirShpilraien MeirShpilraien deleted the fix_publish_ci_remove_debug_derive branch May 4, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants