Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the container is run in a supported architecture for unsupported architectures #16

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make sure the container is run in a supported architecture for unsupported architectures #16

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f8c992
Make sure the container is run in a supported envorinment for other a…
tishun Mar 19, 2024
06e0e68
Platform specified in service definition instead of the shell script
tishun Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#!/bin/bash
export DOCKER_DEFAULT_PLATFORM=linux/amd64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about applying this changes in docker-compose.yml, would it makes more sense? Like this:

platform: linux/amd64

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me check if it has the same result, but quite probably yours is the better approach

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm


if [[ -n "${DOCKER_ACCESS_TOKEN}" ]]; then
echo $DOCKER_ACCESS_TOKEN | docker login --username=$DOCKER_USERNAME --password-stdin
Expand All @@ -15,4 +16,4 @@ docker-compose exec -T node-1 "/opt/join_node.sh"
docker-compose exec -T node-2 "/opt/join_node.sh"

## Create DB ##
docker-compose exec -T master-node "/opt/create_db.sh"
docker-compose exec -T master-node "/opt/create_db.sh"
Loading