Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added yandex 1B subset dataset generator #4

Merged
merged 3 commits into from
Mar 7, 2022

Conversation

DvirDukhan
Copy link

No description provided.

@DvirDukhan DvirDukhan requested a review from GuyAv46 March 7, 2022 08:07
from joblib import Parallel, delayed
import multiprocessing

def read_fbin(filename, start_idx=0, chunk_size=None):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider having float and int as parameters?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure why we need the two functions and not only float, but it is code duplication beside the type, and maybe in the future we will want to support more types

return arr.reshape(nvecs, dim)


def write_fbin(filename, vecs):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as for the read commands

f.attrs['point_type'] = point_type
print('train size: %9d * %4d' % train.shape)
print('test size: %9d * %4d' % test.shape)
f.create_dataset('train', (len(train), len(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an ann_benchmark function?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

write_output(train=train_set, test=test_set, fn=f'Text-to-Image-{size}M.hd5f', distance=distance, point_type='float', count=100)

if __name__ == "__main__":
create_ds()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't get this comment :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line

@DvirDukhan DvirDukhan merged commit e714dd8 into multiclient_tool Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants